8000 [HttpKernel] HttpKernel Don't allow installing HttpKernel 3.2 with WebProfilerBundle 3.1 by derrabus · Pull Request #20558 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] HttpKernel Don't allow installing HttpKernel 3.2 with WebProfilerBundle 3.1 #20558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpKernel] HttpKernel Don't allow installing HttpKernel 3.2 with WebProfilerBundle 3.1 #20558

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Member
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none

The data collection in HttpKernel 3.2 is not compatible with WebProfilerBundle 3.1, probably due to the changes of #19614. At least in my environment, PHP errors like deprecations don't show up in the logs view of the profiler.

My suggestion would be to disallow installing those incompatible versions together.

@nicolas-grekas
Copy link
Member

Do the deprecations show at all in another tab? Can you see the other log levels? Why can't you upgrade WebProfilerBundle to 3.2? Or did you selectivity update HttpKernel only?

@derrabus
Copy link
Member Author

@nicolas-grekas No, the deprecations don't show at all, although there are quite a lot in that project.

I cannot upgrade WebProfilerBundle, because it wants me to upgrade EventDispatcher to 3.2, but EventDispatcher is pinned to 2.8 because we still have some old Guzzle 3 logic in our project. So, if we could get WebProfilerBundle to work with the old EventDispatcher, my problem would be gone completely.

This PR on the other hand is just a documentation of the status-quo.

@nicolas-grekas
Copy link
Member

What's your version of MonogBundle and MonologBridge? Can you see the other log levels?

@derrabus
Copy link
Member Author

And for me, it would be fine if my project is pinned to Symfony 3.1 with some 2.8 components until we migrated that old code from Guzzle 3 to Guzzle 6. It's in our backlog anyway.

@derrabus
Copy link
Member Author
derrabus commented Nov 18, 2016 •
edited
Loading

Other logs appear fine, it's just the deprecations that don't show up. Oh, and it's a Silex 2 project. I'm using the Monolog integration that comes with Silex. Monolog Bridge is at 3.2.

@derrabus
Copy link
Member Author
derrabus commented Nov 18, 2016 •
edited
Loading

I just tinkered a bit more with the project. If I throw out Guzzle 3 and upgrade EventDispatcher and WebProfilerBundle to 3.2, the log tab is completely broken:

Neither the property "counterrors" nor one of the methods "counterrors()", "getcounterrors()"/"iscounterrors()" or "__call()" exist and have public access in class "Symfony\Component\HttpKernel\DataCollector\ConfigDataCollector" in "@WebProfiler/Collector/logger.html.twig" at line 35.

This is probably something, I should report to the Silex project, I guess?

/edit: I just discovered that this issue is already filed as #20557.

@derrabus
Copy link
Member Author

I managed to get WebProfilerBundle 3.2 to work and the issue still persists. So, this PR won't be a solution. I'll close it and open up a bug report after further investigation.

@derrabus derrabus closed this Nov 18, 2016
@derrabus derrabus deleted the master-add-web-profiler-conflit branch November 18, 2016 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpKernel Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0