Fixed generation mistake in changelog #20553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I don't think Carson bot likes the short questioner :) Status: reviewed |
|
@sstok The issue is that carson doesn't check if both "yes" and "no" are present in the corresponding columns, and since I wanted to submit this PR quickly, I do not took the time to cleanup the template at first :) |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Nov 18, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- Fixed generation mistake in changelog | Q | A | ------------- | --- | Branch? | "master" | Fixed tickets |n/a | License | MIT | Doc PR | n/a Commits ------- c30ec36 Fixed generation mistake in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.