[DI] Fix error when trying to resolve a DefinitionDecorator #20543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b654edd to
37bfb16
Compare
xabbuh
reviewed
Nov 17, 2016
| @@ -840,6 +840,10 @@ public function findDefinition($id) | |||
| */ | |||
| public function createService(Definition $definition, $id, $tryProxy = true) | |||
| { | |||
| if ($definition instanceof DefinitionDecorator) { | |||
There was a problem hiding this comment.
What about checking this in a more generic way (i.e. forbidding all Definition subclasses)?
37bfb16 to
8e0da2f
Compare
|
👍 |
1 similar comment
|
👍 |
fabpot
reviewed
Nov 17, 2016
| @@ -840,6 +840,10 @@ public function findDefinition($id) | |||
| */ | |||
| public function createService(Definition $definition, $id, $tryProxy = true) | |||
| { | |||
| if ('Symfony\Component\DependencyInjection\Definition' !== get_class($definition)) { | |||
| throw new RuntimeException(sprintf('Constructing service "%s" from a %s is not supported at build time.', $id, get_class($definition))); | |||
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 17, 2016
…r (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [DI] Fix error when trying to resolve a DefinitionDecorator | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Instead of the currently obscure `ReflectionException: Class does not exist` message, let's throw a useful error message. Commits ------- 8e0da2f [DI] Fix error when trying to resolve a DefinitionDecorator
This was referenced Nov 21, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the currently obscure
ReflectionException: Class does not existmessage, let's throw a useful error message.