[DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider #20540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes (but the behavior doesn't change) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20514 |
| License | MIT |
| Doc PR | symfony/symfony-docs#5993 (already merged) |
cd3a0fe to
d9f48d7
Compare
d9f48d7 to
80d818f
Compare
ogizanagi
reviewed
Nov 16, 2016
| @@ -55,7 +55,7 @@ public function loadUserByUsername($username) | |||
| throw new \InvalidArgumentException(sprintf('You must either make the "%s" entity Doctrine Repository ("%s") implement "Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface" or set the "property" option in the corresponding entity provider configuration.', $this->classOrAlias, get_class($repository))); | |||
| } | |||
|
|
|||
| @trigger_error('Implementing loadUserByUsername from Symfony\Component\Security\Core\User\UserProviderInterface is deprecated since version 2.8 and will be removed in 3.0. Implement the Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface instead.', E_USER_DEPRECATED); | |||
| @trigger_error('Having a Doctrine repository implementing Symfony\Component\Security\Core\User\UserProviderInterface for loading users is deprecated since version 2.8 and will not work in 3.0. Make the repository implement Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
WDYT of:
- Having a Doctrine repository implementing Symfony\Component\Security\Core\User\UserProviderInterface for loading users is deprecated since version 2.8 and will not work in 3.0. Make the repository implement Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface instead.
+ Implementing "Symfony\Component\Security\Core\User\UserProviderInterface" in a Doctrine repository is deprecated since version 2.8 and will not work in 3.0. Implement "Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface" instead.?
There was a problem hiding this comment.
I thought about implementing in, looks indeed better after reading it :).
About the part you removed, just implementing UserProviderInterface in a doctrine repository is still ok (no matter the why) so I think it would be clearer to mention that the deprecation is only about when using the entity provider. From what you given, what do you think about
Implementing Symfony\Component\Security\Core\User\UserProviderInterface in a Doctrine repository for loading users through an entity provider is deprecated since version 2.8 and will not work in 3.0. Make the repository implement Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface instead.
?
There was a problem hiding this comment.
The load users could be removed, keeping just that it's only when using the entity provider, but I fail at obtaining the right sentence ^^
There was a problem hiding this comment.
no matter the why
Indeed I've removed this part because it's unlikely to be implemented in another context 😅
But if you consider it's better to keep it, it's fine to me :)
There was a problem hiding this comment.
- Implementing Symfony\Component\Security\Core\User\UserProviderInterface in a Doctrine repository for loading users through an entity provider is deprecated since version 2.8 and will not work in 3.0. Make the repository implement Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface instead.
+ Implementing Symfony\Component\Security\Core\User\UserProviderInterface in a Doctrine repository used as an entity provider is deprecated since version 2.8 and will not work in 3.0. Make the repository implement Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface instead.?
7f4d4f0 to
ca2a136
Compare
…g UserProviderInterface using the entity provider
ca2a136 to
127af57
Compare
|
👍 |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Nov 18, 2016
…f implementing UserProviderInterface using the entity provider (chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes (but the behavior doesn't change) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20514 | License | MIT | Doc PR | symfony/symfony-docs#5993 (already merged) Commits ------- 127af57 [DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.