8000 [YAML] PHPDoc fixes for inline parser/dumper by ro0NL · Pull Request #20444 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[YAML] PHPDoc fixes for inline parser/dumper #20444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2016
Merged

[YAML] PHPDoc fixes for inline parser/dumper #20444

merged 1 commit into from
Nov 9, 2016

Conversation

ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Nov 7, 2016
Q A
Branch? "master"
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

@fabpot
Copy link
Member
fabpot commented Nov 9, 2016

Is it really just for master? I think most (if not all) applies to 2.7 as well.

@ro0NL
Copy link
Contributor Author
ro0NL commented Nov 9, 2016

You're right.. havent checked it yet :) just proposed the change first. Ill have a look tonight 👍

@ro0NL ro0NL changed the base branch from master to 2.7 November 9, 2016 17:29
@ro0NL
Copy link
Contributor Author
ro0NL commented Nov 9, 2016

@fabpot ready.

@stof
Copy link
Member
stof commented Nov 9, 2016

👍

@fabpot
Copy link
Member
fabpot commented Nov 9, 2016

Thank you @ro0NL.

@fabpot fabpot merged commit dd47295 into symfony:2.7 Nov 9, 2016
fabpot added a commit that referenced this pull request Nov 9, 2016
@fabpot
minor #20444 [YAML] PHPDoc fixes for inline parser/dumper (ro0NL)
6953f4f 
This PR was merged into the 2.7 branch.

Discussion
----------

[YAML] PHPDoc fixes for inline parser/dumper

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | comma-separated list of tickets fixed by the PR, if any
| License       | MIT
| Doc PR        | reference to the documentation PR, if any

Commits
-------

dd47295 fixed phpdoc
@ro0NL ro0NL deleted the patch-2 branch November 10, 2016 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ro0NL @fabpot @stof @carsonbot
0