[Form] fixed "empty_value" option deprecation #20425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a06630 to
f186f6f
Compare
| @@ -39,6 +39,9 @@ | |||
|
|
|||
| class ChoiceType extends AbstractType | |||
| { | |||
| // To be removed in 3.0 | |||
| const DEPRECATED_EMPTY_VALUE = '__deprecated_empty_value__'; | |||
There was a problem hiding this comment.
@nicolas-grekas done :)
f186f6f to
7e84907
Compare
|
ping @fabpot :) |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Dec 3, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Form] fixed "empty_value" option deprecation | Q | A | ------------- | --- | Branch? | 2.x only | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15945 (comment) | License | MIT | Doc PR | ~ I didn't make any profiling but a resolver instance is passed to `configureOptions()` creating locale variables including those exceptions for each field using one of the patched form types, so I guess the memory usage can grow really fast. Commits ------- 7e84907 [Form] fixed "empty_value" option deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't make any profiling but a resolver instance is passed to
configureOptions()creating locale variables including those exceptions for each field using one of the patched form types, so I guess the memory usage can grow really fast.