10000 [SecurityBundle] FirewallConfig's user_checker should be mandatory by chalasr · Pull Request #20407 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] FirewallConfig's user_checker should be mandatory #20407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2016
Merged

[SecurityBundle] FirewallConfig's user_checker should be mandatory #20407

merged 1 commit into from
Nov 4, 2016

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Nov 4, 2016
Q A
Branch? master
Tests pass? yes
Fixed tickets #20404 (comment)
License MIT

@chalasr chalasr mentioned this pull request Nov 4, 2016
Merged
@xabbuh
Copy link
Member
xabbuh commented Nov 4, 2016

👍

@chalasr chalasr force-pushed the firewallconfig/user_checker_is_mandatory branch from f453c25 to cc5cbc9 Compare November 4, 2016 14:07
@chalasr
Copy link
Member Author
chalasr commented Nov 4, 2016

Rebased after #20404

fabpot
fabpot reviewed Nov 4, 2016
View reviewed changes
src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php
$this->listeners = $listeners;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chalasr chalasr force-pushed the firewallconfig/user_checker_is_mandatory branch from cc5cbc9 to e9c8959 Compare November 4, 2016 14:28
@chalasr chalasr force-pushed the firewallconfig/user_checker_is_mandatory branch from e9c8959 to 6754af2 Compare November 4, 2016 14:30
@fabpot
Copy link
Member
fabpot commented Nov 4, 2016

Thank you @chalasr.

@fabpot fabpot merged commit 6754af2 into symfony:master Nov 4, 2016
fabpot added a commit that referenced this pull request Nov 4, 2016
@fabpot
minor #20407 [SecurityBundle] FirewallConfig's user_checker should be…
fc557db 
… mandatory (chalasr)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[SecurityBundle] FirewallConfig's user_checker should be mandatory

| Q             | A
| ------------- | ---
| Branch?       | master
| Tests pass?   | yes
| Fixed tickets | #20404 (comment)
| License       | MIT

Commits
-------

6754af2 [SecurityBundle] FirewallConfig's user_checker should be mandatory
@chalasr chalasr deleted the firewallconfig/user_checker_is_mandatory branch November 4, 2016 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

Assignees
No one assigned
Labels
SecurityBundle Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @xabbuh @fabpot @carsonbot
0