[Serializer] Fix DataUriNormalizer's regex #20286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20225 |
| License | MIT |
| Doc PR | n/a |
|
Travis error not related. |
alekitto
reviewed
Oct 24, 2016
| @@ -85,7 +85,7 @@ public function supportsNormalization($data, $format = null) | |||
| */ | |||
| public function denormalize($data, $class, $format = null, array $context = array()) | |||
| { | |||
| if (!preg_match('/^data:([a-z0-9]+\/[a-z0-9]+(;[a-z0-9\-]+\=[a-z0-9\-]+)?)?(;base64)?,[a-z0-9\!\$\&\\\'\,\(\)\*\+\,\;\=\-\.\_\~\:\@\/\?\%\s]*\s*$/i', $data)) { | |||
| if (!preg_match('/^data:([a-z0-9]+\/[a-z0-9\-\.\+]+(;[a-z0-9\-]+\=[a-z0-9\-]+)?)?(;base64)?,[a-z0-9\!\$\&\\\'\,\(\)\*\+\,\;\=\-\.\_\~\:\@\/\?\%\s]*\s*$/i', $data)) { | |||
There was a problem hiding this comment.
I think the - should be in the first part of mime also, to match types like x-conference/x-cooltalk
|
I've updated the regex to be as close as possible of the ABNF syntax: https://tools.ietf.org/html/rfc6838#section-4.2 |
|
ping @symfony/deciders |
|
👍 LGTM |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Nov 11, 2016
This PR was squashed before being merged into the 3.1 branch (closes #20286). Discussion ---------- [Serializer] Fix DataUriNormalizer's regex | Q | A | | --- | --- | | Branch? | 3.1 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | #20225 | | License | MIT | | Doc PR | n/a | Commits ------- 5dc5dc8 [Serializer] Fix DataUriNormalizer's regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.