8000 [DI] Allow fetching env vars with lookup-dedicated services by nicolas-grekas · Pull Request #20276 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Allow fetching env vars with lookup-dedicated services #20276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[DI] Allow fetching env vars with lookup-dedicated services #20276

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
685ff0e
[DI] Fix YamlDumper not dumping abstract and autoconfigure
nicolas-grekas Aug 10, 2017
6760127
restrict reflection doc block
ElectricMaxxx Aug 10, 2017
3d54c3b
bug #23854 [DI] Fix YamlDumper not dumping abstract and autoconfigure…
nicolas-grekas Aug 10, 2017
c396e8c
[DI] Fix dumping abstract with YamlDumper
nicolas-grekas Aug 10, 2017
f534315
bug #23848 restrict reflection doc block (ElectricMaxxx)
nicolas-grekas Aug 10, 2017
1b9619c
bug #23856 [DI] Fix dumping abstract with YamlDumper (nicolas-grekas)
nicolas-grekas Aug 10, 2017
daa0251
Merge branch '2.7' into 2.8
nicolas-grekas Aug 10, 2017
72791d6
Merge branch '2.8' into 3.3
nicolas-grekas Aug 10, 2017
d1c754d
Merge branch '3.3' into 3.4
nicolas-grekas Aug 10, 2017
eeaea83
fix merge
nicolas-grekas Aug 10, 2017
2a84059
[DI] Allow fetching env vars with lookup-dedicated services
nicolas-grekas Oct 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/DependencyInjection/Dumper/YamlDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ private function addService($id, $definition)
$code .= sprintf(" factory_class: %s\n", $this->dumper->dump($definition->getFactoryClass(false)));
}

if ($definition->isAbstract()) {
$code .= " abstract: true\n";
}

if ($definition->isLazy()) {
$code .= " lazy: true\n";
}
Expand Down
12 changes: 12 additions & 0 deletions src/Symfony/Component/DependencyInjection/Tests/Dumper/YamlDumperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
namespace Symfony\Component\DependencyInjection\Tests\Dumper;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Dumper\YamlDumper;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\Yaml\Yaml;

class YamlDumperTest extends TestCase
Expand Down Expand Up @@ -84,6 +86,16 @@ public function testDumpAutowireData()
$this->assertStringEqualsFile(self::$fixturesPath.'/yaml/services24.yml', $dumper->dump());
}

public function testDumpLoad()
{
$container = new ContainerBuilder();
$loader = new YamlFileLoader($container, new FileLocator(self::$fixturesPath.'/yaml'));
$loader->load('services_dump_load.yml');

$dumper = new YamlDumper($container);
$this->assertStringEqualsFile(self::$fixturesPath.'/yaml/services_dump_load.yml', $dumper->dump());
}

private function assertEqualYamlStructure($yaml, $expected, $message = '')
{
$this->assertEquals(Yaml::parse($expected), Yaml::parse($yaml), $message);
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services_dump_load.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

services:
foo:
abstract: true
0