[HttpFoundation] Avoid implicit null to array conversion in request matcher #20275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Oct 22, 2016
| @@ -76,13 +76,13 @@ public function __construct($path = null, $host = null, $methods = null, $ips = | |||
| */ | |||
| public function matchScheme($scheme) | |||
| { | |||
| $this->schemes = array_map('strtolower', (array) $scheme); | |||
| $this->schemes = null !== $scheme ? array_map('strtolower', (array) $scheme) : array(); | |||
There was a problem hiding this comment.
Not really needed though. Confused with (array) null actually converting to an empty array, not something like array(null) :)
|
👍 |
|
👍 (failing tests are unrelated) |
|
Good catch, thanks @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Nov 7, 2016
… in request matcher (ro0NL) This PR was squashed before being merged into the 2.7 branch (closes #20275). Discussion ---------- [HttpFoundation] Avoid implicit null to array conversion in request matcher | Q | A | | --- | --- | | Branch? | 2.7 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | comma-separated list of tickets fixed by the PR, if any | | License | MIT | | Doc PR | reference to the documentation PR, if any | `null` is allowed _and_ passed as default value from the constructor. Lets be explicit. Commits ------- a2c0a78 [HttpFoundation] Avoid implicit null to array conversion in request matcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullis allowed and passed as default value from the constructor. Lets be explicit.