10000 Added missing kernel.event_subscriber tag (closes #2012) by jalliot · Pull Request #2021 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Added missing kernel.event_subscriber tag (closes #2012) #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2011
Merged

Added missing kernel.event_subscriber tag (closes #2012) #2021

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b240d4
Implementation of kernel.event_subscriber tag for services.
jalliot Aug 23, 2011
21cf0ac
Backported new behaviour from PR #2148 and removed check for interfac…
jalliot Sep 29, 2011
3223c5a
Removed now useless test
jalliot Sep 29, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed now useless test
  • Loading branch information
@jalliot
jalliot committed Sep 29, 2011
commit 3223c5a1f3c153a586d48b327f41bca8e883767d
9 changes: 0 additions & 9 deletions src/Symfony/Bundle/FrameworkBundle/Tests/ContainerAwareEventDispatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,6 @@ public function testAddASubscriberService()
$dispatcher->dispatch('onEvent', $event);
}

/**
* @expectedException \InvalidArgumentException
*/
public function testTriggerASubscriberDoesntImplementInterface()
{
$dispatcher = new ContainerAwareEventDispatcher(new Container());
$dispatcher->addSubscriberService('service.subscriber', 'Symfony\Bundle\FrameworkBundle\Tests\Service');
}

public function testPreventDuplicateListenerService()
{
$event = new Event();
Expand Down
0