8000 [WebProfilerBundle] Improve Ajax Profiling Performance (javascript) by patrick-mcdougle · Pull Request #20197 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Improve Ajax Profiling Performance (javascript) #20197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2016
Merged

[WebProfilerBundle] Improve Ajax Profiling Performance (javascript) #20197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da621c9
Fix indentation & JS Cleanup
Oct 10, 2016
2c053ee
Rewrite ajax profiling for performance
patrick-mcdougle Oct 11, 2016
9942edd
Remove unnecessary method calls/definitions
patrick-mcdougle Oct 11, 2016
fddff26
Put back the indentation
Oct 16, 2016
65e391c
Replace occurances of querySelectorAll with querySelector
Oct 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary method calls/definitions
  • Loading branch information
@patrick-mcdougle
patrick-mcdougle committed Oct 11, 2016
commit 9942edd42e5b7ea73c5886bfa4e4865947ad5ec8
11 changes: 0 additions & 11 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,6 @@

var noop = function() {};

var collectionToArray = function (collection) {
var length = collection.length || 0,
results = new Array(length);

while (length--) {
results[length] = collection[length];
}

return results;
};

var profilerStorageKey = 'sf2/profiler/';

var request = function(url, onSuccess, onError, payload, options) {
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@
document.getElementById('sfMiniToolbar-{{ token }}').style.display = 'none';
}

Sfjs.renderAjaxRequests();

/* Handle toolbar-info position */
var toolbarBlocks = [].slice.call(el.querySelectorAll('.sf-toolbar-block'));
for (i = 0; i < toolbarBlocks.length; ++i) {
Expand Down
0