[Routing] PhpDumper should follow coding standards #20082
Conversation
4d71286 to
b7291f5
Compare
|
Im not sure this is a real issue... imo. codestyle doesnt really apply to generated code anyway. |
2d9a0e6 to
7cf4772
Compare
|
I'm 👍 I know that these generated files are critical and we shouldn't mess with them; these files are generated for computers, not humans; etc. But the proposed changes look safe and Symfony is a project that should strive for top quality in everything it does, like generating these files. |
|
We'll always be 1 step behind of the codestyle of those files. If it's really important to have them properly formatted, it should be using an up-to-date code formatter (php-cs-fixer?). Imo if readability of generated files is really an issue, I'd rather see them being formated on 1 line and use your IDE or a custom cs fixer on demand when required. |
|
|
||
| return $routes; | ||
| } | ||
|
|
||
| protected function exportArray($array) | ||
| { | ||
| return preg_replace(array('/array \(/', '/,\n *\)/', '/,\n */', '/\n */'), array('array(', ')', ', ', ''), var_export($array, true)); |
There was a problem hiding this comment.
there is a risk of collision with the content of a string here, CS is not worth it imho
There was a problem hiding this comment.
You are right. I thought I had this covered, but I must have missed something (I wrote this code a while back, so I don't remember my reasoning).
I cannot think of an easy way to fix this, so I think I'll just close this PR.
BTW the existing code simply strips newlines – this is also not completely kosher, but it might be enough for the specific arrays in question.
| @@ -371,6 +376,11 @@ private function groupRoutesByHostRegex(RouteCollection $routes) | |||
| return $groups; | |||
| } | |||
|
|
|||
| protected function exportArray($array) | |||
| { | |||
| return preg_replace(array('/array \(/', '/,\n *\)/', '/,\n */', '/\n */'), array('array(', ')', ', ', ''), var_export($array, true)); | |||
While working on #19562 I noticed that Fabbot does not like the PHP code generated by the
PhpGeneratorDumperandPhpMatcherDumper.This patch makes the generated code comply with Symfony's conding standards.