8000 Hide commands from ApplicationDescriptor, but allow invoking by jwdeitch · Pull Request #20029 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Hide commands from ApplicationDescriptor, but allow invoking #20029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 5, 2016
Merged

Hide commands from ApplicationDescriptor, but allow invoking #20029

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b423ab4
Add hidden field
jwdeitch Sep 22, 2016
8d0262f
Update Command.php
jwdeitch Sep 22, 2016
b73f494
Update ApplicationDescription.php
jwdeitch Sep 22, 2016
1add2ad
Update Command.php
jwdeitch Sep 22, 2016
1993196
Update Command.php
jwdeitch Sep 22, 2016
fb1f30c
Update Command.php
jwdeitch Sep 25, 2016
56a8b93
Update Command.php
jwdeitch Sep 25, 2016
cd77139
Update Command.php
jwdeitch Sep 25, 2016
dfc1ac8
Update Command.php
jwdeitch Sep 25, 2016
3efa874
Update Command.php
jwdeitch Sep 25, 2016
e969581
update hidden to public
jwdeitch Sep 29, 2016
6d87837
Update ApplicationDescription.php
jwdeitch Sep 29, 2016
0a3c290
update docblocks and added test
Sep 29, 2016
746dab3
casting setPublic() arg to bool
Sep 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Command.php
  • Loading branch information
@jwdeitch
jwdeitch authored Sep 22, 2016
commit 1add2ad12088453c57cc47d5d59c86ef8509ef8e
5 changes: 3 additions & 2 deletions src/Symfony/Component/Console/Command/Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ public function getName()
return $this->name;
}

/**
/**
* Sets if the command should be hidden from application inspection.
*
* @param bool $hiddenBool To show this command or not
Copy link
Contributor
@ro0NL ro0NL Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp.

Copy link
Contributor
@ro0NL ro0NL Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about To hide the command in application descriptions.

Expand All @@ -457,13 +457,14 @@ public function getName()
public function setHidden($hiddenBool)
Copy link
Contributor
@ro0NL ro0NL Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be $hidden

Copy link
Contributor 8000 Author
@jwdeitch jwdeitch Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed. Thank you sir

{
$this->hidden = $hiddenBool;

return $this;
}

/**
* Returns if the command should be hidden from application inspection.
*
* @return boolean If the command is hidden or not
* @return bool If the command is hidden or not
*/
public function isHidden()
{
Expand Down
0