8000 [DependencyInjection] Env parameterbag fix: use the correct exception class. by paradajozsef · Pull Request #19994 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DependencyInjection] Env parameterbag fix: use the correct exception class. #19994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[DependencyInjection] Env parameterbag fix: use the correct exception class. #19994

wants to merge 2 commits into from

Conversation

paradajozsef
Copy link
Contributor
Q A
Branch? "master"
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Small fix after #19681 No description needed imo. :)

@paradajozsef paradajozsef changed the title [DependencyInjection] Fix: use the correct exception class. [DependencyInjection] Env parameterbag fix: use the correct exception class. Sep 20, 2016
@fabpot
Copy link
Member
fabpot commented Sep 20, 2016

Thank you @paradajozsef.

@fabpot fabpot closed this in 8f8f434 Sep 20, 2016
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 21, 2016
Merged
nicolas-grekas added a commit that referenced this pull request Sep 21, 2016
@nicolas-grekas
minor #19998 [DI] Fix expectedException annotation (nicolas-grekas)
167c14f 
This PR was merged into the 3.2-dev branch.

Discussion
----------

[DI] Fix expectedException annotation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19994
| License       | MIT
| Doc PR        | -

@paradajozsef FYI, phpunit (at least v4.8 we have to use for PHP 5.5 compat) doesn't resolve use statements in `expectedException` annotations. Thanks for the fix btw.

Commits
-------

663bd74 [DI] Fix expectedException
8000
 annotation
jakzal
jakzal reviewed Sep 21, 2016
View reviewed changes
src/Symfony/Component/DependencyInjection/Tests/ParameterBag/EnvPlaceholderParameterBagTest.php
class EnvPlaceholderParameterBagTest extends \PHPUnit_Framework_TestCase
{
/**
* @expectedException InvalidArgumentException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: this needs to be a full class namespace, as PHPUnit doesn't "look" at the use statements (already fixed by Nicolas).

@paradajozsef paradajozsef deleted the env-parameterbag-fix branch September 21, 2016 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakzal jakzal jakzal left review comments

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paradajozsef @fabpot @jakzal @carsonbot
0