[TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25) #19983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes (more about removing deprecation notices from newer versions of Twig) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a (see twigphp/Twig#2123) |
| License | MIT |
| Doc PR | n/a |
fabpot
added a commit
that referenced
this pull request
Sep 19, 2016
…g 1.25) (fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes (more about removing deprecation notices from newer versions of Twig) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a (see twigphp/Twig#2123) | License | MIT | Doc PR | n/a Commits ------- 12350c2 [TwigBridge] removed Twig null nodes (deprecated as of Twig 1.25)
This was referenced Oct 3, 2016
Merged
Merged
Merged
arthens
added a commit
to arthens/safe-translations
that referenced
this pull request
Oct 28, 2016
The current implementation of the parser relies on being able to call node.getNode(...) for null node too. However, null nodes are deprecated as of Twig 1.25 and twig-bridge throws an exception when trying to read a null node, see symfony/symfony#19983 This change fixes the problem by checking if the node exits before getting it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4EAC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.