[DI] Add corresponding service id in some exception messages #19892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why do you consider this as being a new feature? By the way, you should really use the full template in your PR description :) |
Member
Author
|
I tend to consider that enhancing exception messages is not a bug fix but a DX enhancement, thus new feature. But OK for merging on 2.7 also of course. |
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 14, 2016
…ssages (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [DI] Add corresponding service id in some exception messages | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | License | MIT This already helped me figure out where was my mistake :) Commits ------- d739f8d [DI] Add corresponding service id in some exception messages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already helped me figure out where was my mistake :)