Update GroupSequence.php #19862
Closed
Update GroupSequence.php #19862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the docblock example
| @@ -17,7 +17,7 @@ | |||
| * When validating a group sequence, each group will only be validated if all | |||
| * of the previous groups in the sequence succeeded. For example: | |||
| * | |||
| * $validator->validate($address, null, new GroupSequence('Basic', 'Strict')); | |||
| * $validator->validate($address, null, new GroupSequence(['Basic', 'Strict'])); | |||
There was a problem hiding this comment.
Should be using the array()syntax instead as this PR should be merged in 2.7.
|
To be merged in 2.7 instead |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 6, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #19862). Discussion ---------- Update GroupSequence.php | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no Corrected the docblock example Commits ------- c8f3741 Update GroupSequence.php
|
Thank you @vudaltsov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the docblock example