[FrameworkBundle] Incorrect line break in exception message (500 debug page) #19780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | 19041 |
| License | MIT |
| @@ -39,7 +39,7 @@ build: 56 | |||
| font-family: Georgia, "Times New Roman", Times, serif; | |||
| font-size: 20px; | |||
| color: #313131; | |||
| word-break: break-all; | |||
| word-break: keep-all; | |||
There was a problem hiding this comment.
wouldn't it be better to use word-wrap: break-word here?
There was a problem hiding this comment.
@nicolas-bastien You're right, already updated to break-word and rebased the PR
c733790 to
d1cde23
Compare
| @@ -39,7 +39,7 @@ build: 56 | |||
| font-family: Georgia, "Times New Roman", Times, serif; | |||
| font-size: 20px; | |||
| color: #313131; | |||
| word-break: break-all; | |||
| word-break: break-word; | |||
There was a problem hiding this comment.
Should be word-wrap: break-word: break-word is an unofficial value for word-break.
There was a problem hiding this comment.
@nicolas-bastien you're right, http://www.w3.org/TR/css-text-3/#word-wrap
d1cde23 to
f51069b
Compare
|
Thank you @pedroresende. |
fabpot
added a commit
that referenced
this pull request
Sep 6, 2016
…e (500 debug page) (pedroresende) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #19780). Discussion ---------- [FrameworkBundle] Incorrect line break in exception message (500 debug page) | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | [19041](#19041) | License | MIT Commits ------- 1393e3e [FrameworkBundle] Fix Incorrect line break in exception message (500 debug page)
|
@fabpot Sure thing, always glad to help a wonderful project. Btw any special reason for not being added to the list of contributors ? |
|
@pedroresende that list is refreshed periodically. You'll eventually get there :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.