8000 [Yaml] improve changelog and upgrade entries by xabbuh · Pull Request #19731 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] improve changelog and upgrade entries #19731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2016
Merged

[Yaml] improve changelog and upgrade entries #19731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Yaml] improve changelog and upgrade entries
  • Loading branch information
@xabbuh
xabbuh committed Aug 27, 2016
commit e28825656b5e87dab854ad54426f6de6475f0be7
5 changes: 3 additions & 2 deletions UPGRADE-3.2.md
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,6 @@ Yaml
* Support for silently ignoring duplicate keys in YAML has been deprecated and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW can't we add an example for this one? It looks hard to understand when you're not aware of the linked change.

will lead to a `ParseException` in Symfony 4.0.

* Mappings with a colon that is not followed by a space are deprecated and
will lead to a `ParseException` in Symfony 4.0.
* Mappings with a colon (`:`) that is not followed by a whitespace are deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you are talking about the same thing than before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually you just removed the wrong entry (see the following one)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh indeed, good catch. Thank you for the heads up.

and will lead to a `ParseException` in Symfony 4.0 (e.g. `foo:bar` must be
`foo: bar`).
5 changes: 3 additions & 2 deletions UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,9 @@ Translation
Yaml
----

* Mappings with a colon that is not followed by a space are are not
supported anymore and lead to a `ParseException`.
* Mappings with a colon (`:`) that is not followed by a whitespace are not
supported anymore and lead to a `ParseException`(e.g. `foo:bar` must be
`foo: bar`).

* Starting an unquoted string with `%` leads to a `ParseException`.

Expand Down
5 changes: 3 additions & 2 deletions src/Symfony/Component/Yaml/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ CHANGELOG
3.2.0
-----

* Mappings with a colon that is not followed by a space are deprecated and
will lead to a `ParseException` in Symfony 4.0.
* Mappings with a colon (`:`) that is not followed by a whitespace are deprecated
and will lead to a `ParseException` in Symfony 4.0 (e.g. `foo:bar` must be
`foo: bar`).

* Added support for parsing PHP constants:

Expand Down
0