[Console] Register terminal env variables #19724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Register terminal related environment variables. | ||
| */ | ||
| public function registerEnv() |
There was a problem hiding this comment.
I'm not sure we want that method. You should putenv() above directly IMHO.
There was a problem hiding this comment.
Perhaps you're right. This would make this PR a bugfix only (despite the fact it can only target 3.2 right now), but I hesitated. I thought this method would be convenient to easily register all terminal related env vars at once in a script before calling a process, even if that's not much.
But fair enough, I'll remove it for now. (Feature label can be removed)
|
👍 |
1 similar comment
|
👍 |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Console] Register terminal env variables | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19719 | License | MIT | Doc PR | - Solves #19719 by setting `COLUMNS` & `LINES` env vars when running an Application. Those env vars are then meant to be reused when using the Process component. ~~It creates a new `Terminal::registerEnv()` method allowing to register terminal related informations into environment variables. ~~It allows getting "consistent terminal informations" across processes.~~ Unless the env vars handling is backported from the 3.2 `Terminal` class to older branches in the `Application` class, the mentioned issue can't be solved this way. Commits ------- 926bc51 [Console] Register terminal env variables
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #19719 by setting
COLUMNS&LINESenv vars when running an Application.Those env vars are then meant to be reused when using the Process component.
It creates a newTerminal::registerEnv()method allowing to register terminal related informations into environment variables.It allows getting "consistent terminal informations" across processes.Unless the env vars handling is backported from the 3.2
Terminalclass to older branches in theApplicationclass, the mentioned issue can't be solved this way.