8000 [DI] Exclude private services from alternatives by ro0NL · Pull Request #19679 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Exclude private services from alternatives #19679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[DI] Exclude private services from alternatives #19679

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76cae3d
include dynamic services in list of alternatives
ro0NL Aug 20, 2016
ff2fb12
exclude private services from alternatives
ro0NL Aug 20, 2016
01c3651
better test
ro0NL Aug 20, 2016
6bf4107
deprecate including privates in getServiceIds
ro0NL Aug 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
include dynamic services in list of alternatives
  • Loading branch information
@ro0NL
ro0NL committed Aug 20, 2016
commit 76cae3df182b1450a30446176d2bc74a4f847fcf
8 changes: 4 additions & 4 deletions src/Symfony/Component/DependencyInjection/Container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ public function get($id, $invalidBehavior = self::EXCEPTION_ON_INVALID_REFERENCE
}

$alternatives = array();
foreach ($this->services as $key => $associatedService) {
$lev = levenshtein($id, $key);
if ($lev <= strlen($id) / 3 || false !== strpos($key, $id)) {
$alternatives[] = $key;
foreach ($this->getServiceIds() as $knownId) {
$lev = levenshtein($id, $knownId);
if ($lev <= strlen($id) / 3 || false !== strpos($knownId, $id)) {
$alternatives[] = $knownId;
}
}

Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ public function testGetThrowServiceNotFoundException()
{
$sc = new ProjectServiceContainer();
$sc->set('foo', $foo = new \stdClass());
$sc->set('bar', $foo = new \stdClass());
$sc->set('baz', $foo = new \stdClass());

try {
Expand Down
0