8000 [WebProfiler] added support for window.fetch calls in ajax section by ivoba · Pull Request #19576 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfiler] added support for window.fetch calls in ajax section #19576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[WebProfiler] added support for window.fetch calls in ajax section #19576

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af9225d
added support for window.fetch calls in ajax section
ivoba Aug 9, 2016
e080ca1
applied suggested fixes:
ivoba Aug 24, 2016
36cad1e
added type to profiler table, use 2nd argument instead of catch, usin…
ivoba Oct 5, 2016
385279c
fixed polyfill detect
ivoba Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed polyfill detect
  • Loading branch information
@ivoba
ivoba committed Oct 5, 2016
commit 385279c29b5a3ef2f58e468a8e9e7885a9f2eb42
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@

{% if excluded_ajax_paths is defined %}

Copy link
Member
@fabpot fabpot Sep 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra blank line here

if (window.fetch) {
if (window.fetch && window.fetch.polyfill === undefined) {
var oldFetch = window.fetch;
window.fetch = function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about using fetch signature (fetch(url, opt 7B3C ions):promise) instead of relying on arguments? I think it's easier to read

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutly, fixed

var promise = oldFetch.apply(this, arguments);
Expand Down
0