8000 [VarDumper] Relax 1 test failing with latest PHP versions by remicollet · Pull Request #19539 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Relax 1 test failing with latest PHP versions #19539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2016
Merged

[VarDumper] Relax 1 test failing with latest PHP versions #19539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eabbcf0
bumped Symfony version to 2.8.10
fabpot Jul 30, 2016
6703b41
Relax 1 test failing with latest PHP versions
remicollet Aug 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Symfony/Component/HttpKernel/Kernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ abstract class Kernel implements KernelInterface, TerminableInterface
protected $startTime;
protected $loadClassCache;

const VERSION = '2.8.9';
const VERSION_ID = 20809;
const VERSION = '2.8.10-DEV';
const VERSION_ID = 20810;
const MAJOR_VERSION = 2;
const MINOR_VERSION = 8;
const RELEASE_VERSION = 9;
const EXTRA_VERSION = '';
const RELEASE_VERSION = 10;
const EXTRA_VERSION = 'DEV';

const END_OF_MAINTENANCE = '11/2018';
const END_OF_LIFE = '11/2019';
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ public function testCastFileObject()
file: true
dir: false
link: false
%AcsvControl: array:2 [
%AcsvControl: array:%d [
0 => ","
1 => """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we keep these two first lines and add %A for the third one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ;)
But does it really worth it ?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

]
%A]
flags: DROP_NEW_LINE|SKIP_EMPTY
maxLineLen: 0
fstat: array:26 [
Expand Down
0