[Config] Fix (Yaml|Xml)ReferenceDumper for nested prototypes #19480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
This was referenced Aug 8, 2016
fabpot
added a commit
that referenced
this pull request
Sep 14, 2016
…ort (ogizanagi) This PR was merged into the 3.2-dev branch. Discussion ---------- [Config] Fix YamlReferenceDumper prototyped array support | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Also related to #19480 which fixes another prototype issue, but cannot be tested properly on Travis because marked as skipped by this missing implementation. Previous output was: ```yaml [...] parameters: # Prototype name: ~ connections: user: ~ pass: ~ ``` instead of: ```yaml [...] parameters: # Prototype name: ~ connections: # Prototype - user: ~ pass: ~ ``` Commits ------- 063a980 [Config] Fix YamlReferenceDumper prototyped array support
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Sep 16, 2016
…otypes (ogizanagi)
This PR was merged into the 3.2-dev branch.
Discussion
----------
[Config] Fix (Yaml|Xml)ReferenceDumper for nested prototypes
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This tries to fix the nested prototypes case for the `YamlReferenceDumper` and `XmlReferenceDumper`.
### Before
```yml
cms_pages:
# Prototype
page: []
```
### After
```yml
cms_pages:
# Prototype
page:
# Prototype
locale:
title: ~ # Required
path: ~ # Required
```
~~However, the `YamlReferenceDumperTest::testDumper` is marked as skipped, due to another unsupported prototype usage, but that's another issue (the `connections` key). Thus, the bug fix must be tested manually :/ (I'd recommend to merge #19570 first)~~
Commits
-------
1e80510 [Config] Fix YamlReferenceDumper for nested prototypes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix the nested prototypes case for the
YamlReferenceDumperandXmlReferenceDumper.Before
After
However, theYamlReferenceDumperTest::testDumperis marked as skipped, due to another unsupported prototype usage, but that's another issue (theconnectionskey). Thus, the bug fix must be tested manually :/ (I'd recommend to merge #19570 first)