8000 Console table cleanup by ReenExe · Pull Request #19406 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Console table cleanup #19406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Console table cleanup #19406

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e7991ae
covers Console\Helper\Table `style is not defined`
ReenExe Jul 22, 2016
993a77f
move common code logic
ReenExe Jul 22, 2016
c3647ec
test before code -> covers `Table::getStyleDefinition`
ReenExe Jul 22, 2016
db2010c
fix `notice` (Undefined index: `key`)
ReenExe Jul 22, 2016
f1e68d0
use `@expectedException` and rename private method (after review #19406)
ReenExe Jul 25, 2016
04283ac
same condition style
ReenExe Jul 27, 2016
99fe32b
@expectedException from Symfony
ReenExe Jul 28, 2016
9b2e4d4
prefer `isset`
ReenExe Jul 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test before code -> covers Table::getStyleDefinition
  • Loading branch information
@ReenExe
ReenExe committed Jul 22, 2016
commit c3647eca176567bb74bb2c6a6e863418c865069f
9 changes: 9 additions & 0 deletions src/Symfony/Component/Console/Tests/Helper/TableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,15 @@ public function testIsNotDefinedStyleException()
$table->setStyle('absent');
}

public function testGetStyleDefinition()
{
$this->setExpectedException(
'InvalidArgumentException',
'Style "absent" is not defined.'
);
Table::getStyleDefinition('absent');
}

protected function getOutputStream()
{
return new StreamOutput($this->stream, StreamOutput::VERBOSITY_NORMAL, false);
Expand Down
0