8000 [Config] Extra tests for Config component by zomberg · Pull Request #19399 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Extra tests for Config component #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Config] Extra tests for Config component #19399

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98035d0
[Config] Added extra tests for ArrayNodeDefinition class
zomberg Jul 21, 2016
e9b8f0e
[Config] Added extra tests for ExprBuilder class
zomberg Jul 22, 2016
e355e93
[Config] Improved test for ExprBuilder class
zomberg Jul 22, 2016
d70c4ad
[Config] Removed duplicated line in test.
zomberg Jul 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Config] Added extra tests for ExprBuilder class
  • Loading branch information
@zomberg
zomberg committed Jul 25, 2016
commit e9b8f0ec4edb8c53c130dd26b3a4bf090acc4af2
24 changes: 24 additions & 0 deletions src/Symfony/Component/Config/Tests/Definition/Builder/ExprBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,30 @@ public function testThenUnsetExpression()
$this->assertEquals(array(), $this->finalizeTestBuilder($test));
}

/**
* @expectedException \RuntimeException
* @expectedExceptionMessage You must specify an if part.
*/
public function testEndIfPartNotSpecified()
{
$this->getTestBuilder()->end();
}

/**
* @expectedException \RuntimeException
* @expectedExceptionMessage You must specify a then part.
*/
public function testEndThenPartNotSpecified()
{
$builder = $this->getTestBuilder();

$reflection = new \ReflectionProperty($builder, 'ifPart');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need reflection here?

Copy link
Contributor Author
@zomberg zomberg Jul 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You are right. I didn't notice that this is public property. I fixed it.

$reflection->setAccessible(true);
$reflection->setValue($builder, 'test');

$builder->end();
}

/**
* Create a test treebuilder with a variable node, and init the validation.
*
Expand Down
0