8000 [Console] Consistent table header cell format for symfony styleguide by ro0NL · Pull Request #19136 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Consistent table header cell format for symfony styleguide #19136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] Consistent table header cell format for symfony styleguide #19136

wants to merge 1 commit into from

Conversation

ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Jun 21, 2016 •
edited
Loading
Q A
Branch? master
Bug fix? yes?
New feature? no
BC breaks? no
Deprecations? no?
Tests pass? yes
Fixed tickets #19123
License MIT
Doc PR ~

Looks like a bug/regression to me ;-) however im not totally sure why ->setCellHeaderFormat('%s') was added that explicitly. Seems like nobody knows :)

@ro0NL ro0NL changed the title consistent table header cell format for symfony styleguide [Console] Consistent table header cell format for symfony styleguide Jun 21, 2016
@ro0NL
Copy link
Contributor Author
ro0NL commented Jun 21, 2016 •
edited
Loading

Ok. This seems to be tested... is it a BC break or can it be seen as UI fix? My bin/console debug:config table looks the same :/

@fabpot
Copy link
Member
fabpot commented Jun 22, 2016

We define default "simple" and neutral styles in Table. SymfonyStyle on the contrary is very opinionated about how to display things.

@ro0NL
Copy link
Contributor Author
ro0NL commented Jun 24, 2016 •
8000 edited
Loading

We define default "simple" and neutral styles in Table.

And symfony-style-guide

Imho the following 2 statements should be considered equal;
SymfonyStyle::table()->render() vs Table::setStyle('symfony-style-guide')->render() which seems to be intented also.

@ro0NL ro0NL mentioned this pull request Jun 24, 2016
Closed
@stof
Copy link
Member
stof commented Jun 24, 2016

I tend to agree with @ro0NL here. It is weird that the symfony-style-guide table style does not match the symfony style guide

@fabpot
Copy link
Member
fabpot commented Jun 28, 2016

Closing in favor of #19173

@fabpot fabpot closed this Jun 28, 2016
fabpot added a commit that referenced this pull request Jun 29, 2016
@fabpot
bug #19173 [Console] Decouple SymfonyStyle from TableCell (ro0NL)
96f32b6 
This PR was squashed before being merged into the 2.7 branch (closes #19173).

Discussion
----------

[Console] Decouple SymfonyStyle from TableCell

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Alternative approach, ie BC, for #19136 (i prefer that one though, as it also _fixes_ #19123 )

Commits
-------

51f59d6 [Console] Decouple SymfonyStyle from TableCell
@ro0NL ro0NL deleted the console/table-styleguide branch June 29, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ro0NL @fabpot @stof @carsonbot
0