8000 Fix feature detection for IE by alsciende · Pull Request #19038 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix feature detection for IE #19038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix feature detection for IE #19038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix feature detection for IE 
operator `!` has higher precedence (4) than operator `in` (8). Parentheses are mandatory here.
  • Loading branch information
@alsciende
alsciende authored Jun 13, 2016
commit d4c37ccd0249c33229313b146508a6d178fda2c5
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
var addEventListener;

var el = document.createElement('div');
if (!'addEventListener' in el) {
if (!('addEventListener' in el)) {
addEventListener = function (element, eventName, callback) {
element.attachEvent('on' + eventName, callback);
};
Expand Down
0