[BrowserKit] Bump the dom-crawler minimum version requirement #18980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakzal It seems your e-mail address is wrongly configured for Git, as your user linkage is broken for the commit. |
70a974d to
1215783
Compare
The BrowserKit Client will not work with DomCrawler 2.0 if the CssSelector component is not installed.
|
@sstok oops. Thanks for letting me know. Fixed now :) |
|
2.3 is not maintained anymore :) |
|
@nicolas-grekas Old habbits die hard ;) This should be merged to 2.7, and the conflict on 2.8 should be resolved to |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Jun 6, 2016
…ement (jakzal) This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #18980). Discussion ---------- [BrowserKit] Bump the dom-crawler minimum version requirement | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18826 | License | MIT | Doc PR | - The BrowserKit Client will not work with DomCrawler 2.0 if the CssSelector component is not installed. This will require an amendment when merging into the 2.8 branch. It currently uses `~2.0,>=2.0.5|~3.0.0`, while it should be `~2.1|~3.0.0`. Commits ------- 5579d86 [BrowserKit] Bump dom-crawler minimum version requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BrowserKit Client will not work with DomCrawler 2.0 if the CssSelector component is not installed.
This will require an amendment when merging into the 2.8 branch. It currently uses
~2.0,>=2.0.5|~3.0.0, while it should be~2.1|~3.0.0.