[VarDumper] Add maxDepth & maxStringLength display options #18948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'index' => 'color:#1299DA', | ||
| 'str .max-string-length b' => 'color:#A0A0A0', | ||
| ); | ||
| protected $displayOptions = array( |
d4b7ee9 to
bfb9087
Compare
| display:none; | ||
| } | ||
| pre.sf-dump .max-string-length.collapsed .expanded { | ||
| display:none |
b5526ef to
c7acc7f
Compare
Member
|
@nicolas-grekas Can you finish this one? |
Member
|
@nicolas-grekas What's the status of this one? |
Member
Author
|
I'm on it :) |
c7acc7f to
77da349
Compare
1a83101 to
3321b96
Compare
3839ad5 to
b885c8d
Compare
b885c8d to
998ff33
Compare
Member
Author
|
I finally managed to finish this one. @MGDSoft FYI, I removed the initDepth/maxDepth distinction: it felt strange when playing with the UI. I kept only your initDepth behavior, renamed as maxDepth. See this fiddle to try the resulting behavior (maxDepth=2): Status: needs review |
|
|
||
| /** | ||
| * Configures display options. | ||
| * |
Member
There was a problem hiding this comment.
ahah, you've been doing that for a long time, working on a PR to fix that :)
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull re
8000
quest
Jun 28, 2016
…ions (MGDSoft, nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Add maxDepth & maxStringLength display options | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16741 | License | MIT | Doc PR | - Takes over #18148 to add display options to html dumps. Status: needs work Commits ------- 998ff33 [VarDumper] Tweak display options implementation 58eb665 [VarDumper] Add maxDepth & maxStringLength display options
Contributor
|
Nice :) |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes over #18148 to add display options to html dumps.
Status: needs work