8000 add missing hint for vote() argument type by xabbuh · Pull Request #18928 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

add missing hint for vote() argument type #18928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented May 31, 2016
Q A
Branch? 3.1
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This somehow got lost when the 3.0 branch was merged up.

@fabpot
Copy link
Member
fabpot commented Jun 1, 2016

Good catch, thanks @xabbuh.

@fabpot fabpot merged commit d14f0bf into symfony:3.1 Jun 1, 2016
fabpot added a commit that referenced this pull request Jun 1, 2016
This PR was merged into the 3.1 branch.

Discussion
----------

add missing hint for vote() argument type

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This somehow got lost when the `3.0` branch was merged up.

Commits
-------

d14f0bf add missing hint for vote() argument type
@xabbuh xabbuh deleted the security-upgrade-3.1 branch June 1, 2016 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0