8000 [Console] Fix BC break introduced by #18101 by dunglas · Pull Request #18925 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Fix BC break introduced by #18101 #18925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Console] Fix BC break introduced by #18101 #18925

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b497ba
Fix BC break introduced by #18101
dunglas May 31, 2016
05fbad7
Fix tests
dunglas May 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests
  • Loading branch information
@dunglas
dunglas committed May 31, 2016
commit 05fbad771f9097104a1359d6b9396858de6c45a9
3 changes: 2 additions & 1 deletion ...y/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ public function testProcess($public)
$this->assertTrue($container->hasDefinition($alias));
}

$id = $public ? 'my-command' : 'console.command.symfony_bundle_frameworkbundle_tests_dependencyinjection_compiler_mycommand';
$this->assertTrue($container->hasParameter('console.command.ids'));
$this->assertSame(array('console.command.symfony_bundle_frameworkbundle_tests_dependencyinjection_compiler_mycommand'), $container->getParameter('console.command.ids'));
$this->assertSame(array($id), $container->getParameter('console.command.ids'));
}

public function visibilityProvider()
Expand Down
0