[DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure #18924
Conversation
|
We recently introduced a Maintenance guide for contributions. It's so new that we're still adapting to it, so I'd like to ask something:
To me in this case it would be overkill ... but then perhaps we need to tweak the Maintenance guide. |
edddb1e to
6c9dcc0
Compare
|
@javiereguiluz This fix is not a performance improvement, but a bug fix where the performance improvement was applied where it shouldn't be (i.e. when |
6c9dcc0 to
eefafc5
Compare
|
@webmozart thanks for the info. Everything is fine then! |
|
Looks like not all tests pass with this change. Status: Needs work |
eefafc5 to
e5ed2b0
Compare
| $this->idReader | ||
| ); | ||
|
|
||
| $value = [$this->idReader, 'getIdValue']; |
There was a problem hiding this comment.
should be array(...) for PHP 5.3 compat.
|
@webmozart Can you have a look at the failing tests? |
…ssing a value closure
e5ed2b0 to
f6e5298
Compare
|
Fixed |
|
Thank you @webmozart. |
…der when passing a value closure (webmozart) This PR was merged into the 2.7 branch. Discussion ---------- [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR is porting an optimization done for `loadChoicesForValues()` in 64c80a6 to `loadValuesForChoices()`. Commits ------- f6e5298 [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure
This PR is porting an optimization done for
loadChoicesForValues()in 64c80a6 toloadValuesForChoices().