8000 Fix for #18843 by inso · Pull Request #18861 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix for #18843 #18861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix for #18843 #18861

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65b517b
added test for #18843
May 24, 2016
64b0531
fixed #18843 (fixed detection of normal/associative arrays)
May 24, 2016
3150e45
extracted checking if array is hash to dedicated method and used it i…
May 29, 2016
1f5db46
added test for Inline::isHash
May 29, 2016
b01b057
cs fix
May 29, 2016
ff26a5b
replaced accidentally used short array notation with traditional
May 29, 2016
1bafe3a
marked method as internal
May 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added test for Inline::isHash
  • Loading branch information
Anton Bakai committed May 29, 2016
commit 1f5db46abb86ccff3f8568f6098f1543a7a6aa25
18 changes: 18 additions & 0 deletions src/Symfony/Component/Yaml/Tests/InlineTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,24 @@ public function testParseUnquotedAsteriskFollowedByAComment()
Inline::parse('{ foo: * #foo }');
}

/**
* @dataProvider getDataForIsHash
*/
public function testIsHash($array, $expected)
{
$this->assertSame($expected, Inline::isHash($array));
}

public function getDataForIsHash()
{
return array(
array([], false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use the short array notation as we need to support PHP 5.3.

array([1, 2, 3], false),
array([2 => 1, 1 => 2, 0 => 3], true),
array(['foo' => 1, 'bar' => 2], true),
);
}

protected function getTestsForParse()
{
return array(
Expand Down
0