8000 [DX][DependencyInjection] Make Autowiring exceptions more future friendly by lemoinem · Pull Request #18780 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DX][DependencyInjection] Make Autowiring exceptions more future friendly #18780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2016
Merged

[DX][DependencyInjection] Make Autowiring exceptions more future friendly #18780

merged 1 commit into from
May 19, 2016

Conversation

lemoinem
Copy link
Contributor
Q A
Branch? 2.8, 3.0
Bug fix? no (forward compatibility)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

This is a follow-up on #18766 (3.1, master) and #18691 (2.8, 3.0).

This PR changes the exception messages to the ones introduced in #18766 and #17877. I also unified the tests so they are exactly the same.

This way the error messages will be the same in 2.8 onward.

@lemoinem lemoinem force-pushed the fix/autowiring/future-friendly-exception-message branch from 54e0fc5 to 834f550 Compare May 13, 2016 19:42
@nicolas-grekas
Copy link
Member

👍
Status: reviewed

@dunglas
Copy link
Member
dunglas commented May 16, 2016

👍

@javiereguiluz javiereguiluz added DependencyInjection DX DX = Developer eXperience (anything that improves the experience of using Symfony) Ready labels May 18, 2016
@javiereguiluz javiereguiluz changed the title [DX][DI] Make Autowiring exceptions more future friendly [DX][DependencyInjection] Make Autowiring exceptions more future friendly May 18, 2016
@javiereguiluz
Copy link
Member

👍

1 similar comment
@stof
Copy link
Member
stof commented May 18, 2016

👍

@nicolas-grekas
Copy link
Member

Thank you @lemoinem.

@nicolas-grekas nicolas-grekas merged commit 834f550 into symfony:2.8 May 19, 2016
nicolas-grekas added a commit that referenced this pull request May 19, 2016
@nicolas-grekas
minor #18780 [DX][DependencyInjection] Make Autowiring exceptions mor…
39a18cd 
…e future friendly (lemoinem)

This PR was merged into the 2.8 branch.

Discussion
----------

[DX][DependencyInjection] Make Autowiring exceptions more future friendly

| Q             | A
| ------------- | ---
| Branch?       | 2.8, 3.0
| Bug fix?      | no (forward compatibility)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This is a follow-up on #18766 (3.1, master) and #18691 (2.8, 3.0).

This PR changes the exception messages to the ones introduced in #18766 and #17877. I also unified the tests so they are exactly the same.

This way the error messages will be the same in 2.8 onward.

Commits
-------

834f550 [DX][DI] Make Autowiring exceptions more future friendly
@lemoinem lemoinem deleted the fix/autowiring/future-friendly-exception-message branch September 28, 2016 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection DX DX = Developer eXperience (anything that improves the experience of using Symfony) Ready Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lemoinem @nicolas-grekas @dunglas @javiereguiluz @stof @carsonbot
0