[3.0] Fixed DateTimeInterface comparison #18751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed DateTimeInterface comparaison
|
I was working on that but then I proposed #18548 on 2.3 that should be merged first (if accepted) which would imply rebasing here. The other way leads to too much conflicts imo. |
|
Thank you @francisbesset. |
fabpot
added a commit
that referenced
this pull request
May 13, 2016
This PR was merged into the 3.0 branch. Discussion ---------- [3.0] Fixed DateTimeInterface comparison | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | DateTime class implements the DateTimeInterface. It is useless to compare is a value is an instance of DateTime or DateTimeInterface. Commits ------- 9a0bc99 6544 Fixed DateTimeInterface comparaison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime class implements the DateTimeInterface.
It is useless to compare is a value is an instance of DateTime or DateTimeInterface.