8000 deprecate get() for uncompiled container builders by xabbuh · Pull Request #18728 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

deprecate get() for uncompiled container builders #18728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

deprecate get() for uncompiled container builders #18728

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd7e6c4
deprecate get() for uncompiled container builders
xabbuh May 5, 2016
cadcebf
call get() after the container was compiled
xabbuh May 9, 2016
64f8a7e
prevent calling get() for service_container service
xabbuh May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
call get() after the container was compiled
  • Loading branch information
@xabbuh
xabbuh committed May 9, 2016
commit cadcebf3465b0f6d9ef8f5d76df50ccd54b4989f
2 changes: 2 additions & 0 deletions src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/ContainerBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public function testCreateProxyServiceWithRuntimeInstantiator()
$builder->register('foo1', 'ProxyManagerBridgeFooClass')->setFile(__DIR__.'/Fixtures/includes/foo.php');
$builder->getDefinition('foo1')->setLazy(true);

$builder->compile();

/* @var $foo1 \ProxyManager\Proxy\LazyLoadingInterface|\ProxyManager\Proxy\ValueHolderInterface */
$foo1 = $builder->get('foo1');

Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,11 @@ public function testToolbarConfig($toolbarEnabled, $interceptRedirects, $listene

$this->assertSame($listenerInjected, $this->container->has('web_profiler.debug_toolbar'));

$this->assertSaneContainer($this->getDumpedContainer());

if ($listenerInjected) {
$this->assertSame($listenerEnabled, $this->container->get('web_profiler.debug_toolbar')->isEnabled());
}

$this->assertSaneContainer($this->getDumpedContainer());
}

public function getDebugModes()
Expand Down
0