[2.3][Component/Security] Fixed phpdoc in AnonymousToken constructor for user param #18727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also update the description to describe how the user must be built (like it is done here too). |
|
@xabbuh Done. Do you also want me to update this description: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Security/Core/Authentication/Token/PreAuthenticatedToken.php#L29 and if so in this PR or in a different one? |
|
@eriwin You can do that in this PR too. |
|
Thank you @eriwin. |
fabpot
added a commit
that referenced
this pull request
May 9, 2016
… constructor for user param (eriwin) This PR was squashed before being merged into the 2.3 branch (closes #18727). Discussion ---------- [2.3][Component/Security] Fixed phpdoc in AnonymousToken constructor for user param | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes, phpdoc one | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Updated phpdoc of AnonymousToken $user param from string to string|object since an object is allowed to in the parent AbstractToken: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php#L91 Commits ------- b1c60b4 [2.3][Component/Security] Fixed phpdoc in AnonymousToken constructor for user param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated phpdoc of AnonymousToken $user param from string to string|object since an object is allowed to in the parent AbstractToken: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php#L91