[Cache] Clean RedisAdapter pipelining + FilesystemAdapter #18714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,10 +145,15 @@ protected function doSave(array $values, $lifetime) | |||
| return $ok; | |||
| } | |||
|
|
|||
| private function getFile($id) | |||
| private function getFile($id, $mkdir) | |||
There was a problem hiding this comment.
As false is used everywhere except in one call, what do you think of making it the default value?
d9e0eab to
e68f2e4
Compare
|
👍 |
| @@ -229,55 +229,65 @@ protected function doSave(array $values, $lifetime) | |||
| $failed[] = $id; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I would keep the empty lines for readability
|
shouldn't the update of |
33c5538 to
44e53cd
Compare
|
@stof hirak/prestissimo removed, I just needed it to check if |
|
ping @symfony/deciders votes pending for 3.1-beta which should/may be released tomorrow |
44e53cd to
acf0075
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 12, 2016
…r (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Clean RedisAdapter pipelining + FilesystemAdapter | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR refactorize Redis pipelining so that the case for handling RedisArray is abstracted, thus less bug prone. Commits ------- acf0075 [Cache] Clean RedisAdapter pipelining + FilesystemAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactorize Redis pipelining so that the case for handling RedisArray is abstracted, thus less bug prone.