8000 [console][table] adjust width of colspanned cell. by aitboudad · Pull Request #18686 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[console][table] adjust width of colspanned cell. #18686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2016

Conversation

aitboudad
Copy link
Contributor
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18627
License MIT
Doc PR ~

@@ -521,6 +521,19 @@ private function getColumnWidth($column)
continue;
}

// split the TableCell centent in order to extending width of other columns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what does this comment try to explain. We extend this cell up to the width of the largest column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally when we use colspan, the cells are merged into one and other cells are left blank,
but when we want to calculate the column width we should split the merged cells content in different emptied cells in order to assume the average width of each columns

@fabpot
Copy link
Member
fabpot commented May 13, 2016

Thank you @aitboudad.

@fabpot fabpot merged commit 9b35449 into symfony:2.7 May 13, 2016
fabpot added a commit that referenced this pull request May 13, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[console][table] adjust width of colspanned cell.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18627
| License       | MIT
| Doc PR        | ~

Commits
-------

9b35449 [console][table] adjust width of colspanned cell.
@aitboudad aitboudad deleted the issues_18627 branch May 13, 2016 15:10
@fabpot
Copy link
Member
fabpot commented May 13, 2016

@aitboudad Can you submit a PR for Symfony 2.8? I've reverted the change as I was not able to easily resolve the conflicts, the code is very different. Thanks.

@aitboudad
Copy link
Contributor Author

ok

@aitboudad
Copy link
Contributor Author

@fabpot see #18774

@fabpot fabpot mentioned this pull request May 13, 2016
This was referenced Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0