-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[console][table] adjust width of colspanned cell. #18686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Q | A |
---|---|
Branch? | 2.7 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #18627 |
License | MIT |
Doc PR | ~ |
@@ -521,6 +521,19 @@ private function getColumnWidth($column) | |||
continue; | |||
} | |||
|
|||
// split the TableCell centent in order to extending width of other columns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what does this comment try to explain. We extend this cell up to the width of the largest column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally when we use colspan
, the cells are merged into one and other cells are left blank,
but when we want to calculate the column width we should split the merged cells content in different emptied cells in order to assume the average width of each columns
Thank you @aitboudad. |
This PR was merged into the 2.7 branch. Discussion ---------- [console][table] adjust width of colspanned cell. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18627 | License | MIT | Doc PR | ~ Commits ------- 9b35449 [console][table] adjust width of colspanned cell.
@aitboudad Can you submit a PR for Symfony 2.8? I've reverted the change as I was not able to easily resolve the conflicts, the code is very different. Thanks. |
ok |