[console][table] adjust width of colspanned cell. #18686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18627 |
| License | MIT |
| Doc PR | ~ |
| @@ -521,6 +521,19 @@ private function getColumnWidth($column) | |||
| continue; | |||
| } | |||
|
|
|||
| // split the TableCell centent in order to extending width of other columns | |||
There was a problem hiding this comment.
I don't understand what does this comment try to explain. We extend this cell up to the width of the largest column?
There was a problem hiding this comment.
Normally when we use colspan, the cells are merged into one and other cells are left blank,
but when we want to calculate the column width we should split the merged cells content in different emptied cells in order to assume the average width of each columns
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
May 13, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [console][table] adjust width of colspanned cell. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18627 | License | MIT | Doc PR | ~ Commits ------- 9b35449 [console][table] adjust width of colspanned cell.
|
@aitboudad Can you submit a PR for Symfony 2.8? I've reverted the change as I was not able to easily resolve the conflicts, the code is very different. Thanks. |
|
ok |
Merged
This was referenced Jun 6, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.