8000 [Form] [DoctrineBridge] updated changelogs after #18359 by HeahDude · Pull Request #18664 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Form] [DoctrineBridge] updated changelogs after #18359 #18664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion UPGRADE-3.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ Form
'choice_label' => function ($choice) {
return strtoupper($choice);
},
```
```

* Caching of the loaded `ChoiceListInterface` in the `LazyChoiceList` has been deprecated,
it must be cached in the `ChoiceLoaderInterface` implementation instead.

FrameworkBundle
---------------
Expand Down
2 changes: 2 additions & 0 deletions UPGRADE-4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ Form
},
```

* Caching of the loaded `ChoiceListInterface` in the `LazyChoiceList` has been removed,
it must be cached in the `ChoiceLoaderInterface` implementation instead.

FrameworkBundle
---------------
Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Bridge/Doctrine/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ CHANGELOG
* added "{{ value }}" message placeholder to UniqueEntityValidator
* deprecated `MergeDoctrineCollectionListener::onBind` in favor of
`MergeDoctrineCollectionListener::onSubmit`
* deprecated passing `ChoiceListFactoryInterface` as first argument of
`DoctrineChoiceLoader`'s constructor

3.0.0
-----
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@
*/
class DoctrineChoiceLoader implements ChoiceLoaderInterface
{
/**
* @var ChoiceListFactoryInterface
*/
private $factory;

/**
* @var ObjectManager
*/
Expand Down Expand Up @@ -78,7 +73,6 @@ public function __construct($manager, $class, $idReader = null, $objectLoader =

// Provide a BC layer since $factory has changed
// form first to last argument as of 3.1
$this->factory = $manager;
$manager = $class;
$class = $idReader;
$objectLoader = $factory;
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Form/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ CHANGELOG
* Using callable strings as choice options in `ChoiceType` has been deprecated
and will be used as `PropertyPath` instead of callable in Symfony 4.0.
* implemented `DataTransformerInterface` in `TextType`
* deprecated caching loaded choice list in `LazyChoiceList::$loadedList`

3.0.0
-----
Expand Down
0