10000 [FrameworkBundle] Minor UPGRADE files fix by nicolas-grekas · Pull Request #18648 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Minor UPGRADE files fix #18648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2016
Merged

[FrameworkBundle] Minor UPGRADE files fix #18648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions UPGRADE-3.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,10 @@ FrameworkBundle

```yaml
framework:
serializer: ~
cache:
pools:
serializer:
adapter: cache.adapter.apcu
cache:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to keep this? I'm not sure that everyone will think that removing the serializer section will disable it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc states that enabling should be done explicitly using enabled: true:
http://symfony.com/doc/current/cookbook/serializer.html
That's why I made this change: serializer: ~ could be misleading also.
Not adding it here will force people using implicit enabling to think about it, which is a good thing to me :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @nicolas-grekas here. In this particular example I think it's better to show it like this.

pools:
serializer:
adapter: cache.adapter.apcu

HttpKernel
----------
Expand Down
9 changes: 4 additions & 5 deletions UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,10 @@ FrameworkBundle

```yaml
framework:
serializer: ~
cache:
pools:
serializer:
adapter: cache.adapter.apcu
cache:
pools:
serializer:
adapter: cache.adapter.apcu
```

HttpKernel
Expand Down
0