8000 [FrameworkBundle] Remove duplicated code in ContainerDebugCommand by JhonnyL · Pull Request #18606 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Remove duplicated code in ContainerDebugCommand #18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

JhonnyL
Copy link
Contributor
@JhonnyL JhonnyL commented Apr 21, 2016
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@@ -99,25 +99,21 @@ protected function execute(InputInterface $input, OutputInterface $output)
}

$this->validateInput($input);
$object = $this->getContainerBuilder();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$containerBuilder would be more explicit.

Copy link
Contributor Author
@JhonnyL JhonnyL Apr 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason behind naming it $object is that it could either be an instance of ContainerBuilder or ParameterBag.

@fabpot
Copy link
Member
fabpot commented Apr 26, 2016

Thank you @JhonnyL.

@fabpot fabpot merged commit 5885cbc into symfony:2.7 Apr 26, 2016
fabpot added a commit that referenced this pull request Apr 26, 2016
…ugCommand (JhonnyL)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Remove duplicated code in ContainerDebugCommand

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  |no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

5885cbc [FrameworkBundle] Remove duplicated code in ContainerDebugCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3A44
5 participants
0