[Console] [TableHelper] make it work with SymfonyStyle. #18581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | #18573 |
| License | MIT |
| Doc PR | ~ |
| use Symfony\Component\Console\Tests\Style\SymfonyStyleWithForcedLineLength; | ||
| use Symfony\Component\Console\Helper\TableCell; | ||
|
|
||
| //Ensure questions do not output anything when input is non-interactive |
There was a problem hiding this comment.
This comment needs to be updated.
|
👍 |
| @@ -204,7 +205,16 @@ public function caution($message) | |||
| */ | |||
| public function table(array $headers, array $rows) | |||
| { | |||
| $headers = array_map(function ($value) { return sprintf('<info>%s</>', $value); }, $headers); | |||
| array_walk_recursive($headers, function (&$value) { | |||
There was a problem hiding this comment.
recursive required? Then should we add a test case which would trigger this recursive part?
There was a problem hiding this comment.
not really recusive, but it can be one/two-dimensional array which is already covered by test
|
👍 |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Apr 20, 2016
…itboudad) This PR was merged into the 2.7 branch. Discussion ---------- [Console] [TableHelper] make it work with SymfonyStyle. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #18573 | License | MIT | Doc PR | ~ Commits ------- 43cc93c [Console] [TableHelper] make it work with SymfonyStyle.
|
Question.. would a |
|
@aitboudad any thoughts on this? |
This was referenced Apr 29, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.