[FrameworkBundle] Better output for user in ContainerDebugCommand #18556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I like this improvement. Thanks @JhonnyL |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @JhonnyL. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 20, 2016
…Command (JhonnyL) This PR was merged into the 3.0 branch. Discussion ---------- [FrameworkBundle] Better output for user in ContainerDebugCommand | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Right now, the message `To search for a specific service, re-run this command with a search term. (e.g. debug:container log)` is displayed to the user whenever the command is being run. (Except when the search term is given). But if a user runs e.g. `debug:container --parameters`. This message is out of scope since the user is looking for information about parameters, not services. This PR will update the command to give better output to the user. `debug:container` Will keep current behaviour `debug:container --parameters` Will hint how to search for specific parameter `debug:container --tags` Will hint how to search for specific tag Commits ------- 313d8b1 [FrameworkBundle] Better output for user in ContainerDebugCommand
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the message
To search for a specific service, re-run this command with a search term. (e.g. debug:container log)is displayed to the user whenever the command is being run. (Except when the search term is given).But if a user runs e.g.
debug:container --parameters. This message is out of scope since the user is looking for information about parameters, not services.This PR will update the command to give better output to the user.
debug:containerWill keep current behaviour
debug:container --parametersWill hint how to search for specific parameter
debug:container --tagsWill hint how to search for specific tag