[BUG] Delete class 'control-group' in bootstrap 3 #18507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A |
|---|---|
| Branch? | 3.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18506 |
| License | MIT |
| Doc PR | any |
|
I do not think that we can merge this as someone might already rely on the class being present in their own code. |
|
Do we really need to keep BC here? This is a Bootstrap theme and the class does not exist. |
|
This class does not exist in Bootstrap 3. More, this causes problems to display because this is not the default use of framework. The answers are either the deletion of the class in HTML or add CSS to correct buttons display. |
|
👍 for merge |
|
Thank you @Toelath. |
fabpot
added a commit
that referenced
this pull request
May 13, 2016
…e Degeeter) This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #18507). Discussion ---------- [BUG] Delete class 'control-group' in bootstrap 3 | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18506 | License | MIT | Doc PR | any Commits ------- 99f61d6 [BUG] Delete class 'control-group' in bootstrap 3
Merged
This was referenced Jun 6, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.