Force profiler toolbar svg display #18469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with fixing this ... but I think we should use |
|
Updated with |
|
@pyrech thank you! 👍 |
|
👍 |
|
Thanks @pyrech. |
stof
added a commit
that referenced
this pull request
Apr 7, 2016
This PR was merged into the 2.8 branch. Discussion ---------- Force profiler toolbar svg display | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | - | Fixed tickets | - | License | MIT | Doc PR | - When applying `display: block` on all svg of our website, we found that toolbar's svg were also impacted:  Just apply a default display on toolbar's svg fixes the issue. Commits ------- 467d8c7 Force profiler toolbar svg display
javiereguiluz
added a commit
that referenced
this pull request
Dec 11, 2017
… toolbar. (bobdenotter) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Fix Image/SVG display in WebProfiler toolbar. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This small fix prevents widths from "creeping in" from previously defined CSS rules into the WebProfiler toolbar. See before/after screenshot:  Note: This PR fixes an other issue than #18469, which landed in SF 2.8. Commits ------- 62f5eae Set `width: auto` on WebProfiler toolbar's reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying
display: blockon all svg of our website, we found that toolbar's svg were also impacted:Just apply a default display on toolbar's svg fixes the issue.