[DependencyInjection] Fix tests of #18144 #18422
Conversation
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
5b0da22 to
b524c93
Compare
|
@nicolas-grekas Should be green now :) |
b524c93 to
d7cf9ee
Compare
d7cf9ee to
85d4ac4
Compare
|
If it goes in master we could use |
|
Ok failure unrelated! |
|
Apparently hhvm does not like |
dd9836b to
85d4ac4
Compare
c86595b to
fdbbb1a
Compare
|
👍 |
|
Thank you @HeahDude. |
|
@weaverryan @dunglas I merged this one to make tests green again, please submit a PR if anything is wrong here (with test case :) ) |
| } | ||
|
|
||
| return AutowirePass::createResourceForClass($reflectionClass); | ||
| return @filemtime($this->filePath) <= $timestamp; |
There was a problem hiding this comment.
@HeahDude thanks for fixing the test failure on #18144 - I didn't realize I had left an error!
But, this is wrong! This simplifies this resource down to be basically identical to the SelfCheckingResourceInterface.
The original last line was a mistake - I added a bug in my last commit - this was the mistake: 49271e8#diff-04e2904117929f6ffe784d5be3cb1103R49
So, this should be reverted, but and the last line corrected to be:
return AutowirePass::createResourceForClass($reflectionClass); == $this;Could you make a PR for that?
There was a problem hiding this comment.
@weaverryan Yes, I tried to figure out what to do, I was not sure about that "easy" way :)
Thanks for the lead, I'm on it!
There was a problem hiding this comment.
@weaverryan Is there anyway to add a test for that ?
This PR was merged into the 3.1-dev branch. Discussion ---------- fix Autowiring tests of #18144 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | Tests pass? | yes | Fixed issue | #18422 (comment) | License | MIT Commits ------- 0cbf04a [DI] fix Autowiring tests of #18144
This PR was merged into the 3.1-dev branch. Discussion ---------- fix Autowiring tests of #18144 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | Tests pass? | yes | Fixed issue | symfony/symfony#18422 (comment) | License | MIT Commits ------- 0cbf04a [DI] fix Autowiring tests of #18144