8000 upgrade 3.1/4.0 minor cs fixes by HeahDude · Pull Request #18396 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

upgrade 3.1/4.0 minor cs fixes #18396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2016
Merged

upgrade 3.1/4.0 minor cs fixes #18396

merged 1 commit into from
Apr 1, 2016

Conversation

HeahDude
Copy link
Contributor
@HeahDude HeahDude commented Apr 1, 2016
Q A
Branch? master
License MIT

fabpot
fabpot reviewed Apr 1, 2016
View reviewed changes
UPGRADE-3.1.md
@@ -23,10 +24,11 @@ FrameworkBundle
---------------

* As it was never an officially supported feature, the support for absolute
template paths has been deprecated and will be removed in Symfony 4.0.
template paths in the template name parse has been deprecated and will be
removed in Symfony 4.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted

@HeahDude HeahDude force-pushed the minor/update-3_1-cs_fix branch from a6b3658 to fb08520 Compare April 1, 2016 06:20
@HeahDude HeahDude force-pushed the minor/update-3_1-cs_fix branch from fb08520 to b8e2911 Compare April 1, 2016 06:28
@HeahDude
Copy link
Contributor Author
HeahDude commented Apr 1, 2016

Ok fixed!

@fabpot
Copy link
Member
fabpot commented Apr 1, 2016

Thank you @HeahDude.

@fabpot fabpot merged commit b8e2911 into symfony:master Apr 1, 2016
fabpot added a commit that referenced this pull request Apr 1, 2016
@fabpot
minor #18396 upgrade 3.1/4.0 minor cs fixes (HeahDude)
4b0b3d9 
This PR was merged into the 3.1-dev branch.

Discussion
----------

upgrade 3.1/4.0 minor cs fixes

| Q             | A
| ------------- | ---
| Branch?       | master
| License       | MIT

Commits
-------

b8e2911 upgrade 3.1/4.0 minor fixes
@HeahDude HeahDude deleted the minor/update-3_1-cs_fix branch April 1, 2016 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeahDude @fabpot @carsonbot
0